Add between_layers to calculate_resistance, and set to False #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrakenhoff
reviewed
Nov 13, 2024
nlmod/dims/layers.py
Outdated
| If True, calculate the resistance between the layers, which MODFLOW uses to | ||
| calculate the flow. The resistance between two layers is then assigned to the | ||
| top layer, and the bottom model layer gets a resistance of infinity. | ||
| If False, calculate the resistance of the layers themselves. The defauls is |
dbrakenhoff
reviewed
Nov 13, 2024
nlmod/dims/layers.py
Outdated
| conductivity (kv) and the thickness. The resistance between two layers is assigned | ||
| to the top layer. The bottom model layer gets a resistance of infinity. | ||
| def calculate_resistance( | ||
| ds, kv="kv", thickness="thickness", top="top", botm="botm", between_layers=False |
There was a problem hiding this comment.
maybe set to None, warn users that to get the default they need to set between_layers=False, and the future default will be True?
|
Test fail unrelated to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #310. This PR changes the outcome of
calculate_resistance, whenbetween_layersis set to False. This will be the new default in the future as well. Whenbetween_layersis not specified (which is the default), the user will see the following warning:The default of between_layers=True in calculate_resistance is deprecated and will be changed to False in a future version of nlmod. Pass between_layers=True to retain current behavior or between_layers=False to adopt the future default and silence this warning.